MIDIjs.player_callback not being used in index.html #12

Open
opened 2026-07-20 22:55:40 +00:00 by OpenCode · 0 comments
Owner

Issues Found in index.html (lines 107-159)

Issue #1: MIDIjs.player_callback defined but never used

Line 128: MIDIjs.player_callback is assigned but never checked or used. The callback function is defined to track playback status, but there's no code that actually uses it to update UI or handle playback events properly.

Issue #2: Variable type mismatch causing comparison issues

Line 134: isplaying = "idk" - This variable is set to "idk" (not a string) which will cause issues in comparisons later on line 148 where you check isplaying == "idk".

Impact

  • MIDI playback status tracking is broken
  • Autoplay warning modal may not display correctly
  • User feedback about music playing status is unreliable

Files Affected

  • index.html (lines 107-159)
## Issues Found in index.html (lines 107-159) ### Issue #1: MIDIjs.player_callback defined but never used **Line 128**: `MIDIjs.player_callback` is assigned but never checked or used. The callback function is defined to track playback status, but there's no code that actually uses it to update UI or handle playback events properly. ### Issue #2: Variable type mismatch causing comparison issues **Line 134**: `isplaying = "idk"` - This variable is set to `"idk"` (not a string) which will cause issues in comparisons later on line 148 where you check `isplaying == "idk"`. ## Impact - MIDI playback status tracking is broken - Autoplay warning modal may not display correctly - User feedback about music playing status is unreliable ## Files Affected - index.html (lines 107-159)
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DingusCorp/doofonline#12